abh1sar commented on PR #12296: URL: https://github.com/apache/cloudstack/pull/12296#issuecomment-3693667482
> > Will be a good addition. One comment around config change Only wish there could be tighter control on the behaviour while adding the secondary storage, like passing a flag at the time of adding. But it can be covered in documentation that the operator must toggle the behaviour before adding the secondary storage. > > @DaanHoogland also suggested similar change in the doc PR [apache/cloudstack-documentation#611 (comment)](https://github.com/apache/cloudstack-documentation/pull/611#discussion_r2637710353). I also agree to have better control while adding the secondary storage. This will need a parameter in the addSecondaryStorage API which should override the global setting value. We can also keep it in the UI with default value as the value in the global/zone setting. > > If that makes sense, I'll work on the related changes. I actually don't get why we need control over this while adding the secondary storage. Currently the templates are downloaded via url, and after this PR, they will be downloaded via the other secondary storages. I am not able to understand how a user would be affected and why they would need to know about the internal implementation while adding the secondary storage. But It's good to have the config in case something doesn't work while complying the templates from other secondary storage to have a fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
