Fixed Coverity Issues Reported
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/7bbe7fc6 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/7bbe7fc6 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/7bbe7fc6 Branch: refs/heads/master Commit: 7bbe7fc6974f39567700e9b418615c8e9a92fb19 Parents: 16b1746 Author: Santhosh Edukulla <santhosh.eduku...@gmail.com> Authored: Fri Jul 25 16:41:17 2014 +0530 Committer: Santhosh Edukulla <santhosh.eduku...@gmail.com> Committed: Fri Jul 25 16:41:17 2014 +0530 ---------------------------------------------------------------------- .../org/apache/cloudstack/storage/volume/VolumeServiceImpl.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/7bbe7fc6/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java ---------------------------------------------------------------------- diff --git a/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java index 3fc43ea..821c939 100644 --- a/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java +++ b/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java @@ -1464,8 +1464,9 @@ public class VolumeServiceImpl implements VolumeService { } // Delete volumes which are not present on DB. - for (Long uniqueName : volumeInfos.keySet()) { - TemplateProp tInfo = volumeInfos.get(uniqueName); + for (Map.Entry<Long,TemplateProp> entry : volumeInfos.entrySet()) { + Long uniqueName = entry.getKey(); + TemplateProp tInfo = entry.getValue(); //we cannot directly call expungeVolumeAsync here to // reuse delete logic since in this case, our db does not have
