Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

[via GitHub]

rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332313971


##########
api/src/main/java/org/apache/cloudstack/api/response/Site2SiteVpnConnectionResponse.java:
##########
@@ -31,29 +31,29 @@
 @SuppressWarnings("unused")
 public class Site2SiteVpnConnectionResponse extends BaseResponse implements 
ControlledEntityResponse {
     @SerializedName(ApiConstants.ID)
-    @Param(description = "the connection ID")
+    @Param(description = "The connection ID")
     private String id;
 
     @SerializedName(ApiConstants.S2S_VPN_GATEWAY_ID)
-    @Param(description = "the vpn gateway ID")
+    @Param(description = "The VPN gateway ID")
     private String vpnGatewayId;
 
     @SerializedName(ApiConstants.PUBLIC_IP)
-    @Param(description = "the public IP address")
+    @Param(description = "The public IP address")
     //from VpnGateway
     private String ip;
 
     @SerializedName(ApiConstants.S2S_CUSTOMER_GATEWAY_ID)
-    @Param(description = "the customer gateway ID")
+    @Param(description = "The customer gateway ID")
     private String customerGatewayId;
 
     @SerializedName(ApiConstants.GATEWAY)
-    @Param(description = "public ip address id of the customer gateway")
+    @Param(description = "Public IP address id of the customer gateway")

Review Comment:
   'ID'



##########
api/src/main/java/org/apache/cloudstack/api/response/Site2SiteVpnConnectionResponse.java:
##########
@@ -83,65 +83,65 @@ public class Site2SiteVpnConnectionResponse extends 
BaseResponse implements Cont
     private Long espLifetime;
 
     @SerializedName(ApiConstants.DPD)
-    @Param(description = "if DPD is enabled for customer gateway")
+    @Param(description = "If DPD is enabled for customer gateway")
     //from CustomerGateway
     private Boolean dpd;
 
     @SerializedName(ApiConstants.FORCE_ENCAP)
-    @Param(description = "if Force NAT Encapsulation is enabled for customer 
gateway")
+    @Param(description = "If Force NAT Encapsulation is enabled for customer 
gateway")
     //from CustomerGateway
     private Boolean encap;
 
     @SerializedName(ApiConstants.STATE)
-    @Param(description = "State of vpn connection")
+    @Param(description = "State of VPN connection")
     private String state;
 
     @SerializedName(ApiConstants.PASSIVE)
-    @Param(description = "State of vpn connection")
+    @Param(description = "State of VPN connection")
     private boolean passive;
 
     @SerializedName(ApiConstants.ACCOUNT)
-    @Param(description = "the owner")
+    @Param(description = "The owner")
     private String accountName;
 
     @SerializedName(ApiConstants.PROJECT_ID)
-    @Param(description = "the project id")
+    @Param(description = "The project id")

Review Comment:
   'ID'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org