rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332086650
##########
api/src/main/java/org/apache/cloudstack/api/response/FirewallResponse.java:
##########
@@ -28,63 +28,63 @@
@SuppressWarnings("unused")
public class FirewallResponse extends BaseResponse {
@SerializedName(ApiConstants.ID)
- @Param(description = "the ID of the firewall rule")
+ @Param(description = "The ID of the firewall rule")
private String id;
@SerializedName(ApiConstants.PROTOCOL)
- @Param(description = "the protocol of the firewall rule")
+ @Param(description = "The protocol of the firewall rule")
private String protocol;
@SerializedName(ApiConstants.START_PORT)
- @Param(description = "the starting port of firewall rule's port range")
+ @Param(description = "The starting port of firewall rule's port range")
private Integer startPort;
@SerializedName(ApiConstants.END_PORT)
- @Param(description = "the ending port of firewall rule's port range")
+ @Param(description = "The ending port of firewall rule's port range")
private Integer endPort;
@SerializedName(ApiConstants.IP_ADDRESS_ID)
- @Param(description = "the public ip address id for the firewall rule")
+ @Param(description = "The public IP address id for the firewall rule")
private String publicIpAddressId;
@SerializedName(ApiConstants.NETWORK_ID)
- @Param(description = "the network id of the firewall rule")
+ @Param(description = "The Network id of the firewall rule")
Review Comment:
'ID'
##########
api/src/main/java/org/apache/cloudstack/api/response/FirewallResponse.java:
##########
@@ -28,63 +28,63 @@
@SuppressWarnings("unused")
public class FirewallResponse extends BaseResponse {
@SerializedName(ApiConstants.ID)
- @Param(description = "the ID of the firewall rule")
+ @Param(description = "The ID of the firewall rule")
private String id;
@SerializedName(ApiConstants.PROTOCOL)
- @Param(description = "the protocol of the firewall rule")
+ @Param(description = "The protocol of the firewall rule")
private String protocol;
@SerializedName(ApiConstants.START_PORT)
- @Param(description = "the starting port of firewall rule's port range")
+ @Param(description = "The starting port of firewall rule's port range")
private Integer startPort;
@SerializedName(ApiConstants.END_PORT)
- @Param(description = "the ending port of firewall rule's port range")
+ @Param(description = "The ending port of firewall rule's port range")
private Integer endPort;
@SerializedName(ApiConstants.IP_ADDRESS_ID)
- @Param(description = "the public ip address id for the firewall rule")
+ @Param(description = "The public IP address id for the firewall rule")
private String publicIpAddressId;
@SerializedName(ApiConstants.NETWORK_ID)
- @Param(description = "the network id of the firewall rule")
+ @Param(description = "The Network id of the firewall rule")
private String networkId;
@SerializedName(ApiConstants.IP_ADDRESS)
- @Param(description = "the public ip address for the firewall rule")
+ @Param(description = "The public IP address for the firewall rule")
private String publicIpAddress;
@SerializedName(ApiConstants.STATE)
- @Param(description = "the state of the rule")
+ @Param(description = "The state of the rule")
private String state;
@SerializedName(ApiConstants.CIDR_LIST)
- @Param(description = "the cidr list to forward traffic from. Multiple
entries are separated by a single comma character (,).")
+ @Param(description = "The CIDR list to forward traffic from. Multiple
entries are separated by a single comma character (,).")
private String cidrList;
@SerializedName(ApiConstants.ICMP_TYPE)
- @Param(description = "type of the icmp message being sent")
+ @Param(description = "Type of the icmp message being sent")
Review Comment:
'ICMP'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
