weizhouapache commented on code in PR #10735:
URL: https://github.com/apache/cloudstack/pull/10735#discussion_r2330738988
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2718,6 +2718,19 @@ public PingCommand getCurrentStatus(final long id) {
return new PingStorageCommand(Host.Type.Storage, id, new
HashMap<String, Boolean>());
}
+ protected void configureStorageNetwork(Map<String, Object> params) {
+ _storageIp = MapUtils.getString(params, "storageip");
+ _storageNetmask = (String) params.get("storagenetmask");
+ _storageGateway = (String) params.get("storagegateway");
+ if (_storageIp == null && _inSystemVM && _eth1ip != null) {
+ logger.info("Storage network not configured, using management
network[ip: {}, netmask: {}, gateway: {}] for storage traffic",
+ _eth1ip, _eth1mask, _localgw);
Review Comment:
`_localgw` is not set at this point, it is set in line 2817 (new line number)
@shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
