rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2303227344
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/ListDedicatedGuestVlanRangesCmd.java:
##########
@@ -44,33 +44,33 @@ public class ListDedicatedGuestVlanRangesCmd extends
BaseListCmd {
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
GuestVlanRangeResponse.class, description = "list dedicated guest vlan ranges
by id")
+ @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
GuestVlanRangeResponse.class, description = "List dedicated guest vlan ranges
by id")
private Long id;
@Parameter(name = ApiConstants.ACCOUNT,
type = CommandType.STRING,
- description = "the account with which the guest VLAN range is
associated. Must be used with the domainId parameter.")
+ description = "The account with which the guest VLAN range is
associated. Must be used with the domainId parameter.")
private String accountName;
- @Parameter(name = ApiConstants.PROJECT_ID, type = CommandType.UUID,
entityType = ProjectResponse.class, description = "project who will own the
guest VLAN range")
+ @Parameter(name = ApiConstants.PROJECT_ID, type = CommandType.UUID,
entityType = ProjectResponse.class, description = "Project who will own the
guest VLAN range")
private Long projectId;
@Parameter(name = ApiConstants.DOMAIN_ID,
type = CommandType.UUID,
entityType = DomainResponse.class,
- description = "the domain ID with which the guest VLAN range is
associated. If used with the account parameter, returns all guest VLAN ranges
for that account in the specified domain.")
+ description = "The domain ID with which the guest VLAN range is
associated. If used with the account parameter, returns all guest VLAN ranges
for that account in the specified domain.")
private Long domainId;
- @Parameter(name = ApiConstants.GUEST_VLAN_RANGE, type =
CommandType.STRING, description = "the dedicated guest vlan range")
+ @Parameter(name = ApiConstants.GUEST_VLAN_RANGE, type =
CommandType.STRING, description = "The dedicated guest vlan range")
Review Comment:
'VLAN' instead of 'vlan'?
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/ListDedicatedGuestVlanRangesCmd.java:
##########
@@ -44,33 +44,33 @@ public class ListDedicatedGuestVlanRangesCmd extends
BaseListCmd {
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
GuestVlanRangeResponse.class, description = "list dedicated guest vlan ranges
by id")
+ @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
GuestVlanRangeResponse.class, description = "List dedicated guest vlan ranges
by id")
private Long id;
@Parameter(name = ApiConstants.ACCOUNT,
type = CommandType.STRING,
- description = "the account with which the guest VLAN range is
associated. Must be used with the domainId parameter.")
+ description = "The account with which the guest VLAN range is
associated. Must be used with the domainId parameter.")
private String accountName;
- @Parameter(name = ApiConstants.PROJECT_ID, type = CommandType.UUID,
entityType = ProjectResponse.class, description = "project who will own the
guest VLAN range")
+ @Parameter(name = ApiConstants.PROJECT_ID, type = CommandType.UUID,
entityType = ProjectResponse.class, description = "Project who will own the
guest VLAN range")
private Long projectId;
@Parameter(name = ApiConstants.DOMAIN_ID,
type = CommandType.UUID,
entityType = DomainResponse.class,
- description = "the domain ID with which the guest VLAN range is
associated. If used with the account parameter, returns all guest VLAN ranges
for that account in the specified domain.")
+ description = "The domain ID with which the guest VLAN range is
associated. If used with the account parameter, returns all guest VLAN ranges
for that account in the specified domain.")
private Long domainId;
- @Parameter(name = ApiConstants.GUEST_VLAN_RANGE, type =
CommandType.STRING, description = "the dedicated guest vlan range")
+ @Parameter(name = ApiConstants.GUEST_VLAN_RANGE, type =
CommandType.STRING, description = "The dedicated guest vlan range")
private String guestVlanRange;
@Parameter(name = ApiConstants.PHYSICAL_NETWORK_ID,
type = CommandType.UUID,
entityType = PhysicalNetworkResponse.class,
- description = "physical network id of the guest VLAN range")
+ description = "Physical network id of the guest VLAN range")
Review Comment:
'id' or 'ID'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
