weizhouapache commented on code in PR #10898: URL: https://github.com/apache/cloudstack/pull/10898#discussion_r2282024733
########## engine/schema/templateConfig.sh: ########## @@ -79,7 +79,7 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" mkdir -p $PARENTPATH -METADATAFILE=${PARENTPATH}"metadata.ini" -echo > $METADATAFILE +METADATAFILE="${PARENTPATH}metadata.ini" +echo > "$METADATAFILE" SOURCEFILE=${PARENTPATH}'md5sum.txt' Review Comment: ```suggestion SOURCEFILE="${PARENTPATH}md5sum.txt" ``` ########## engine/schema/templateConfig.sh: ########## @@ -54,7 +54,7 @@ function getChecksum() { function createMetadataFile() { local fileData=$(cat $SOURCEFILE) Review Comment: ```suggestion local fileData=$(cat "$SOURCEFILE") ``` ########## engine/schema/templateConfig.sh: ########## @@ -79,7 +79,7 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" mkdir -p $PARENTPATH Review Comment: ```suggestion mkdir -p "$PARENTPATH" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
