sureshanaparti commented on code in PR #11379:
URL: https://github.com/apache/cloudstack/pull/11379#discussion_r2278786896
##########
server/src/main/java/org/apache/cloudstack/user/UserPasswordResetManagerImpl.java:
##########
@@ -69,7 +68,7 @@ public class UserPasswordResetManagerImpl extends ManagerBase
implements UserPas
new ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, String.class,
"user.password.reset.mail.template", "Hello {{username}}!\n" +
"You have requested to reset your password. Please click the
following link to reset your password:\n" +
- "http://{{{resetLink}}}\n"; +
+ "https://your_domain_here{{{resetLink}}}\n"; +
Review Comment:
```suggestion
"{{{domainUrl}}}{{{resetLink}}}\n" +
```
@daviftorres Can consider any of the options below to improve this.
- use domainUrl as place holder, and set it to
_ManagementServerAddresses.value().split(",")[0]_ as earlier if it exists
(operator has to replace this with their domain, otherwise default to
management server address - needs to be documented).
- use a new config 'user.password.reset.mail.domain.url', default is empty
and it takes management server address as earlier. Operator can configure their
domain url (http://example.com, https://example.com, etc) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
