shwstppr commented on code in PR #11435:
URL: https://github.com/apache/cloudstack/pull/11435#discussion_r2272482011
##########
engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java:
##########
@@ -168,16 +168,26 @@ public List<HypervisorType>
getAvailableHypervisorInZone(Long zoneId) {
.collect(Collectors.toList());
}
+ /**
+ * Returns distinct (HypervisorType, CPUArch) pairs from clusters in the
given zone,
+ * excluding clusters with {@link HypervisorType#External}.
+ *
+ * @param zoneId the zone ID to filter by, or {@code null} to include all
zones
+ * @return list of unique hypervisor type and CPU architecture pairs
+ */
@Override
public List<Pair<HypervisorType, CPU.CPUArch>>
listDistinctHypervisorsArchAcrossClusters(Long zoneId) {
Review Comment:
I feel the method name should reflect the change to avoid confusion and
wrong usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
