DaanHoogland commented on code in PR #11313:
URL: https://github.com/apache/cloudstack/pull/11313#discussion_r2238910149
##########
server/src/main/java/com/cloud/api/query/dao/SnapshotJoinDaoImpl.java:
##########
@@ -96,9 +97,27 @@ private void setSnapshotInfoDetailsInResponse(SnapshotJoinVO
snapshot, SnapshotR
} else {
snapshotResponse.setRevertable(snapshotInfo.isRevertable());
snapshotResponse.setPhysicalSize(snapshotInfo.getPhysicalSize());
+
+ boolean showChainSize =
SnapshotManager.snapshotShowChainSize.valueIn(snapshot.getDataCenterId());
+ if (showChainSize && snapshotInfo.getParent() != null) {
+ long chainSize = calculateChainSize(snapshotInfo);
+ snapshotResponse.setChainSize(chainSize);
+ }
}
}
+ private long calculateChainSize(SnapshotInfo snapshotInfo) {
Review Comment:
I think we would rather get the chain size (as opposed to the total size of
the chain) and check that the actual chain is not longer. Not sure if there is
a way of getting that that is not the same method as following it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
