shwstppr commented on code in PR #11303:
URL: https://github.com/apache/cloudstack/pull/11303#discussion_r2236194981


##########
api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java:
##########
@@ -60,6 +62,12 @@ public class UpdateClusterCmd extends BaseCmd {
             since = "4.20")
     private String arch;
 
+    @Parameter(name = ApiConstants.EXTERNAL_DETAILS,
+            type = CommandType.MAP,
+            description = "Details in key/value pairs to be added to the 
extension-resource mapping. Use the format externaldetails[i].<key>=<value>. 
Example: externaldetails[0].endpoint.url=https://example.com";,
+            since = "4.21.0")
+    protected Map externalDetails;

Review Comment:
   This is the general patter followed in our code and type is not needed as we 
use convertDetailsToMap in the getter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to