shwstppr commented on code in PR #11302:
URL: https://github.com/apache/cloudstack/pull/11302#discussion_r2236182898
##########
server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java:
##########
@@ -401,6 +400,9 @@ public List<HostJoinVO> findByClusterId(Long clusterId,
Host.Type type) {
}
private String calculateResourceAllocatedPercentage(float resource, float
resourceWithOverProvision) {
+ if (resource == 0 || resourceWithOverProvision == 0) {
Review Comment:
I don't agree. When we know value is zero why do the calculation
unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
