DaanHoogland commented on code in PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#discussion_r2230380987
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -3105,7 +3105,7 @@ public Volume detachVolumeFromVM(DetachVolumeCmd cmmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception getting
the outcome of the asynchronous detach volume job", e);
```
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -3534,7 +3534,7 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception
getting the outcome of the asynchronous migrate volume job", e);
```
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -649,7 +649,7 @@ public boolean deleteVMSnapshot(Long vmSnapshotId) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception getting
the outcome of the asynchronous delete VM snapshot job", e);
```
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -3876,7 +3876,7 @@ private Snapshot takeSnapshotInternal(Long volumeId, Long
policyId, Long snapsho
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception
getting the outcome of the asynchronous take volume snapshot job", e);
```
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -1025,7 +1025,7 @@ public boolean deleteAllVMSnapshots(long vmId,
VMSnapshot.Type type) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception getting
the outcome of the asynchronous delete snapshots job", e);
```
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -774,7 +774,7 @@ public UserVm revertToSnapshot(Long vmSnapshotId) throws
InsufficientCapacityExc
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception getting
the outcome of the asynchronous revert to snapshot job", e);
```
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -4201,7 +4201,7 @@ public String extractVolume(ExtractVolumeCmd cmd) {
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception
getting the outcome of the asynchronous extract volume job", e);
```
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -539,7 +539,7 @@ public VMSnapshot createVMSnapshot(Long vmId, Long
vmSnapshotId, Boolean quiesce
} catch (InterruptedException e) {
throw new RuntimeException("Operation is interrupted", e);
} catch (java.util.concurrent.ExecutionException e) {
- throw new RuntimeException("Execution excetion", e);
+ throw new RuntimeException("Execution exception", e);
Review Comment:
```suggestion
throw new CloudRuntimeException("Execution exception getting
the outcome of the asynchronous create VM snapshot job", e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
