sureshanaparti commented on code in PR #11244:
URL: https://github.com/apache/cloudstack/pull/11244#discussion_r2230347425
##########
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##########
@@ -1716,6 +1716,11 @@ private boolean checkConditionUp(AutoScaleVmGroupVO
asGroup, Integer numVm) {
s_logger.warn("number of VM will greater than the maximum in this
group if scaling up, so do nothing more");
return false;
}
+ int erroredInstanceCount =
autoScaleVmGroupVmMapDao.getErroredInstanceCount(asGroup.getId());
+ if (erroredInstanceCount >
AutoScaleManager.AutoScaleErroredInstanceThreshold.value()) {
+ s_logger.warn("number of Errored Instances are greater than the
threshold in this group for scaling up, so do nothing more");
Review Comment:
```suggestion
s_logger.warn("Number of Errored Instances are greater than the
threshold in this group for scaling up, so do nothing more");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
