Pearl1594 commented on code in PR #11291:
URL: https://github.com/apache/cloudstack/pull/11291#discussion_r2229291464
##########
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java:
##########
@@ -331,13 +335,13 @@ public void setUpdated(Date updated) {
}
};
- public static final Map<Hypervisor.HypervisorType, Integer>
hypervisorGuestOsMap = new HashMap<Hypervisor.HypervisorType, Integer>() {
+ public static Map<Hypervisor.HypervisorType, Integer> hypervisorGuestOsMap
= new HashMap<Hypervisor.HypervisorType, Integer>() {
{
- put(Hypervisor.HypervisorType.KVM, LINUX_5_ID);
- put(Hypervisor.HypervisorType.XenServer, OTHER_LINUX_ID);
- put(Hypervisor.HypervisorType.VMware, OTHER_LINUX_ID);
Review Comment:
I don't think it matters, but historically, we've used `Other Linux
(64-bits)` for the XS and Vmware.
https://docs.cloudstack.apache.org/en/4.15.1.0/upgrading/upgrade/upgrade-4.14.html#update-system-vm-templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
