sureshanaparti commented on code in PR #10458:
URL: https://github.com/apache/cloudstack/pull/10458#discussion_r2222957736
##########
api/src/main/java/com/cloud/network/element/NetworkElement.java:
##########
@@ -87,6 +88,12 @@ boolean prepare(Network network, NicProfile nic,
VirtualMachineProfile vm, Deplo
boolean release(Network network, NicProfile nic, VirtualMachineProfile vm,
ReservationContext context) throws ConcurrentOperationException,
ResourceUnavailableException;
+ /**
+ * Release IP from the network provider if reserved
+ * @param ipAddress
+ */
+ boolean releaseIp(IpAddress ipAddress);
Review Comment:
```suggestion
default boolean releaseIp(IpAddress ipAddress) {
return true;
}
```
have this default implementation (don't override wherever not required)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
