rohityadavcloud commented on code in PR #11221: URL: https://github.com/apache/cloudstack/pull/11221#discussion_r2210011358
########## services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/network/NioSocketHandler.java: ########## @@ -20,6 +20,8 @@ public interface NioSocketHandler { + int DEFAULT_BUF_SIZE = 64 * 1024; // 64KiB Review Comment: I've upped the buffer size from 16 to 64KiB; this is solely based on manual performance testing. A typical TLS plaintext payload is 16KiB, so the buffer needs to be at least 16384. This does not mean websocket packets will be all 64KiB, but upto/max 64KiB. Before the fix, they were max. 200 bytes which cause slowness in desktop based consoles. Now, this is increased to up to 64KiB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org