DaanHoogland commented on code in PR #11214: URL: https://github.com/apache/cloudstack/pull/11214#discussion_r2209943580
########## server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java: ########## @@ -480,6 +480,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso, ResponseView view) { isoResponse.setExtractable(iso.isExtractable() && !(iso.getTemplateType() == TemplateType.PERHOST)); isoResponse.setCreated(iso.getCreatedOnStore()); isoResponse.setDynamicallyScalable(iso.isDynamicallyScalable()); + isoResponse.setFormat(iso.getFormat()); Review Comment: @sureshanaparti , I think this is a requirement from an automation pov (i.e. using terraform) I don’t think it hurts to add it. ########## server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java: ########## @@ -480,6 +480,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso, ResponseView view) { isoResponse.setExtractable(iso.isExtractable() && !(iso.getTemplateType() == TemplateType.PERHOST)); isoResponse.setCreated(iso.getCreatedOnStore()); isoResponse.setDynamicallyScalable(iso.isDynamicallyScalable()); + isoResponse.setFormat(iso.getFormat()); Review Comment: (but you are right) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org