weizhouapache commented on code in PR #11210:
URL: https://github.com/apache/cloudstack/pull/11210#discussion_r2208968562
##########
systemvm/debian/opt/cloud/bin/setup/common.sh:
##########
@@ -683,7 +683,7 @@ getPublicIp() {
setup_ntp() {
log_it "Setting up NTP"
- NTP_CONF_FILE="/etc/ntp.conf"
+ NTP_CONF_FILE="/etc/ntpsec/ntp.conf"
Review Comment:
hmm, `/etc/ntp.conf` does not exist in 4.20 template either
##########
server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java:
##########
@@ -258,6 +258,9 @@ public class ConsoleProxyManagerImpl extends ManagerBase
implements ConsoleProxy
protected Set<State> availableVmStateOnAssignProxy = new
HashSet<>(Arrays.asList(State.Starting, State.Running, State.Stopping,
State.Migrating));
+ static final ConfigKey<String> CPVMNTPServerConfig = new
ConfigKey<String>(String.class, "cpvm.ntp.server.list", "Advanced", null,
Review Comment:
can we use the existing `NTPServerConfig` ?
##########
server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java:
##########
@@ -1276,6 +1279,10 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
buf.append("
vmpassword=").append(configurationDao.getValue("system.vm.password"));
}
+ if (CPVMNTPServerConfig.value() != null) {
Review Comment:
use StringUtils.isNotEmpty instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
