weizhouapache commented on PR #11132:
URL: https://github.com/apache/cloudstack/pull/11132#issuecomment-3055406715
> @weizhouapache upto you. Without any change in Java code I feel the new
test would fail because it is using a self-signed certificate and SSL
verification is set to true. For the test or a user's use-case sslverification
can be set to false which should allow delivery to work fine.
Thanks @shwstppr
I understand a bit on your logic now.
- if ssl certfication is false, use trust all.
- if ssl cerification is true, use the default ssl trust store.
I think the logic is correct. Maybe one thing can be improved is, adding
the cloudstack mangement store to trust store, so the https server which uses
the certificate issued by cloudstack CA, such as the https server in the new
test, can work.
I will update the PR (java code) so the logic will be kept, and new test
with https server will pass too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
