hsato03 commented on PR #11138: URL: https://github.com/apache/cloudstack/pull/11138#issuecomment-3049749871
> > The regression was introduced by commit [a0080a0](https://github.com/apache/cloudstack/commit/a0080a04fe66b1b1cf1f67bb674a079d7cab857a) as the `accountId` ([a0080a0#diff-d2867d8cb1ef1dd180f2cf4a9c8c69086ffcd4153b7f3c7c2211b0d49920ac62R857](https://github.com/apache/cloudstack/commit/a0080a04fe66b1b1cf1f67bb674a079d7cab857a#diff-d2867d8cb1ef1dd180f2cf4a9c8c69086ffcd4153b7f3c7c2211b0d49920ac62R857)) parameter is null while updating domains resource count, which caused the `moveDomain` API to stop working as well. > > Perhaps ensuring that `accountId` is not null before using it would be enough to fix the issue. > > no, I think an accountid should not be obligatory when updating limit counts on a domain. But a null check (and making the code you point to not be called if it is null) would seem in order. Yes, that's what I meant. My last comment was a bit ambiguous, sorry 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
