Copilot commented on code in PR #11145:
URL: https://github.com/apache/cloudstack/pull/11145#discussion_r2185391241


##########
plugins/network-elements/juniper-contrail/src/test/java/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java:
##########
@@ -239,8 +239,7 @@ public Object answer(InvocationOnMock invocation) {
         try {
             _vmMgr.addVmToNetwork(vm, network, profile);
         } catch (Exception ex) {
-            // TODO Auto-generated catch block
-            //ex.printStackTrace();
+            // ignored

Review Comment:
   Silently ignoring all exceptions in a test mock can hide unexpected 
failures; consider at least logging the exception or asserting specific 
exception types.
   ```suggestion
               logger.warning("Exception occurred while adding VM to network: " 
+ ex.getMessage());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to