shwstppr commented on code in PR #9752:
URL: https://github.com/apache/cloudstack/pull/9752#discussion_r2184380458
##########
api/src/main/java/com/cloud/agent/api/Command.java:
##########
@@ -60,6 +61,7 @@ public enum State {
private int wait; //in second
private boolean bypassHostMaintenance = false;
private transient long requestSequence = 0L;
+ protected Map<String, Map<String, String>> externalDetails;
Review Comment:
@DaanHoogland yes, externalDetails is more appropriate here as these are
filtered details and used by extensions specific code. Many of the resources
already have a details property and would be a bit confusing.
Also, Answer class that extends Command has a member named details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
