DaanHoogland commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r2182851158
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -374,11 +368,11 @@ protected boolean filter(ExcludeList avoid, StoragePool
pool, DiskProfile dskCh,
storageMgr.isStoragePoolCompliantWithStoragePolicy(dskCh.getDiskOfferingId(),
pool) :
storageMgr.isStoragePoolCompliantWithStoragePolicy(requestVolumeDiskProfilePairs,
pool);
if (!isStoragePoolStoragePolicyCompliance) {
- logger.debug(String.format("Skipping allocation of pool
[%s] to volume [%s] because this pool is not compliant with the storage policy
required by the volume.", pool, volume));
+ logger.debug("Skipping allocation of pool [{}] to volume
[{}] because this pool is not compliant with the storage policy required by the
volume.", pool, volume);
return false;
}
} catch (StorageUnavailableException e) {
- logger.warn(String.format("Could not verify storage policy
complaince against storage pool %s due to exception %s", pool.getUuid(),
e.getMessage()));
+ logger.warn("Could not verify storage policy complaince
against storage pool [{}] due to exception [{}]", pool.getUuid(),
e.getMessage());
Review Comment:
```suggestion
logger.warn("Could not verify storage policy compliance
against storage pool [{}] due to exception [{}]", pool.getUuid(),
e.getMessage());
```
sorry for the late remark,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
