JoaoJandre commented on PR #11042: URL: https://github.com/apache/cloudstack/pull/11042#issuecomment-3023754113
> @JoaoJandre Thanks a lot for the feedback! I agree that test naming should be clear and intuitive. > > From what I’ve seen, most tests in the Apache CloudStack codebase follow conventions like `test<MethodName>` or `test<SomeBehavior>`, without necessarily repeating the method name being tested if it's already implied. In this PR, all the tests are focused on `getConfigResources`, I tried to keep the names focused on the specific behaviors being tested to keep things readable. > > That said, if you feel the `<methodName>Test<BehaviorBeingTested>` format would make things clearer, I’d be happy to rename the tests. Totally open to aligning with whatever the team prefers! @he1l0world currently there is no set convention that you must abide by as far as I know. But it is my opinion that it would make the tests easier to understand. In any case, on a first glance I did not see anything wrong/weird with your tests. I'll review them again soon just to be sure (as I said, I'm still not very familiar with this part of the code). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
