shwstppr commented on code in PR #11075:
URL: https://github.com/apache/cloudstack/pull/11075#discussion_r2177328584
##########
ui/src/components/view/InfoCard.vue:
##########
@@ -35,7 +35,7 @@
<resource-icon :image="resourceIcon" size="4x"
style="margin-right: 5px"/>
</span>
<span v-else>
- <os-logo v-if="resource.ostypeid || resource.ostypename
|| ['guestoscategory'].includes($route.path.split('/')[1])"
:osId="resource.ostypeid" :osName="resource.ostypename || resource.name"
size="3x" @update-osname="setResourceOsType"/>
+ <os-logo v-if="resource.ostypeid || resource.ostypename
|| ['guestoscategory'].includes($route.path.split('/')[1])"
:osId="resource.ostypeid" :osName="resource.ostypename ||
resource.osdisplayname || resource.name" size="3x" />
Review Comment:
@fmaximus I could be wrong but I think OS Type was not showing for VMs
before,
https://github.com/apache/cloudstack/commit/bce17b627d1cc186c3be5257e529cce384dfaa9f
listVirtualMachines API already returns with `osdisplayname` and I think it
is better to show that. It should be returning same name as returned by
listOsTypes API.
IMO, a display component like OsLogo shouldn't update resource details.
Are you observing any issue where it was showing CentOS earlier and now
showing CentOS 9 with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
