shwstppr commented on code in PR #10899:
URL: https://github.com/apache/cloudstack/pull/10899#discussion_r2176532525


##########
ui/src/api/index.js:
##########
@@ -23,18 +23,10 @@ import {
   ACCESS_TOKEN
 } from '@/store/mutation-types'
 
-export function api (command, args = {}, method = 'GET', data = {}) {

Review Comment:
   @sureshanaparti wouldn't it be easier to refactor this method itself to 
enforce use of POST/GET based on configuration/API type. We won't have to 
modify each caller in that case. Current change will cause merge conflicts for 
almost all UI related active PRs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to