weizhouapache commented on code in PR #11054:
URL: https://github.com/apache/cloudstack/pull/11054#discussion_r2156292410
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java:
##########
@@ -320,6 +320,11 @@ public AboutInfo getHostAboutInfo() throws Exception {
public VmwareHostType getHostType() throws Exception {
AboutInfo aboutInfo = getHostAboutInfo();
+ if (aboutInfo == null) {
+ String msg = "no type info about host known"
+ s_logger.error(msg)
+ throw new Exception(msg);
Review Comment:
I never face this issue before, but I know some users have faced the issue.
If we throw an Exception with message, instead of NPE, I think it does not
help, as user will still get an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
