rohityadavcloud commented on code in PR #10986:
URL: https://github.com/apache/cloudstack/pull/10986#discussion_r2136963257
##########
scripts/util/create-kubernetes-binaries-iso.sh:
##########
@@ -19,41 +19,50 @@
set -e
if [ $# -lt 6 ]; then
- echo "Invalid input. Valid usage: ./create-kubernetes-binaries-iso.sh
OUTPUT_PATH KUBERNETES_VERSION CNI_VERSION CRICTL_VERSION
WEAVENET_NETWORK_YAML_CONFIG DASHBOARD_YAML_CONFIG BUILD_NAME"
+ echo "Invalid input. Valid usage: ./create-kubernetes-binaries-iso.sh
OUTPUT_PATH KUBERNETES_VERSION CNI_VERSION CRICTL_VERSION
WEAVENET_NETWORK_YAML_CONFIG DASHBOARD_YAML_CONFIG BUILD_NAME [ARCH]"
echo "eg: ./create-kubernetes-binaries-iso.sh ./ 1.11.4 0.7.1 1.11.1
https://github.com/weaveworks/weave/releases/download/latest_release/weave-daemonset-k8s-1.11.yaml
https://raw.githubusercontent.com/kubernetes/dashboard/v1.10.0/src/deploy/recommended/kubernetes-dashboard.yaml
setup-v1.11.4"
exit 1
fi
+ARCH="amd64"
+if [ -n "${8}" ]; then
+ ARCH="${8}"
+ if [ "$ARCH" != "amd64" ] && [ "$ARCH" != "arm64" ]; then
+ echo "ERROR: ARCH must be 'amd64' or 'arm64'. If the optional parameter
ARCH is not set then 'amd64' is used."
Review Comment:
For sake of simplicity, check what arch type k8s uses in its urls (it that
arm64 or aarch64) ? So the script can still take in aarch64 as input, but
produce the output with arch-name as used by k8s urls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
