vits-hugs commented on code in PR #10898: URL: https://github.com/apache/cloudstack/pull/10898#discussion_r2103174500
########## engine/schema/templateConfig.sh: ########## @@ -79,7 +79,7 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" mkdir -p $PARENTPATH -METADATAFILE=${PARENTPATH}"metadata.ini" -echo > $METADATAFILE +METADATAFILE="${PARENTPATH}metadata.ini" +echo > "$METADATAFILE" SOURCEFILE=${PARENTPATH}'md5sum.txt' Review Comment: They should not have problems, since on line 80 it's certain that the PARENTPATH variable will be a String, so line 81 and 84 should always work properly even with spaces on the paths. If you find any test case that triggers an error please report to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
