DaanHoogland commented on code in PR #10769:
URL: https://github.com/apache/cloudstack/pull/10769#discussion_r2057876652
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1026,8 +1026,15 @@ public Configuration updateConfiguration(final
UpdateCfgCmd cmd) throws InvalidP
if (value.isEmpty() || value.equals("null")) {
value = (id == null) ? null : "";
}
- final String updatedValue = updateConfiguration(userId, name,
category, value, scope, id);
+
+ String currentValueInScope = getConfigurationValueInScope(config,
name, scope, id);
+ final String updatedValue = updateConfiguration(userId, name,
category, value, scope.name(), id);
Review Comment:
maybe change the type of `scope` in `updateConfiguration()` as well to be a
`ConfigKey.Scope`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
