weizhouapache commented on code in PR #10423:
URL: https://github.com/apache/cloudstack/pull/10423#discussion_r2032047447


##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -909,31 +909,41 @@ protected boolean doDeleteHost(final long hostId, final 
boolean isForced, final
         // Verify that host exists
         final HostVO host = _hostDao.findById(hostId);
         if (host == null) {
-            throw new InvalidParameterValueException("Host with id " + hostId 
+ " doesn't exist");
+            String errorMessage = String.format("Host with ID [%s] was not 
found", hostId);

Review Comment:
   > ```suggestion
   >             String errorMessage = String.format("Host with UUID [%s] was 
not found", host.getUuid());
   > ```
   
   This will cause NPE as host is null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to