Pearl1594 commented on code in PR #10583:
URL: https://github.com/apache/cloudstack/pull/10583#discussion_r2014773829
##########
test/integration/smoke/test_events_resource.py:
##########
@@ -161,21 +157,12 @@ def test_01_events_resource(self):
virtual_machine.restore(self.apiclient)
time.sleep(self.services["sleep"])
virtual_machine.detach_volume(self.apiclient, volume)
- volume.delete(self.apiclient)
- self.cleanup.remove(volume)
ts = str(time.time())
virtual_machine.update(self.apiclient, displayname=ts)
- virtual_machine.delete(self.apiclient)
- self.cleanup.remove(virtual_machine)
account_network.update(self.apiclient, name=account_network.name + ts)
- account_network.delete(self.apiclient)
- self.cleanup.remove(account_network)
+ virtual_machine.start(self.apiclient)
Review Comment:
@shwstppr I removed the delete resource operations because it did not matter
in terms of the events being generated. As the test doesn't check the type of
event being generated for a resource, but rather just checking if events for a
resource are generated. And the cleanup is happening via the teardown process.
Regarding the start operation, it was noticed that if a VM is restored - it
loses its root disk, hence the test was failing on vmware during the deletion
of the vm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
