Pearl1594 commented on code in PR #10289:
URL: https://github.com/apache/cloudstack/pull/10289#discussion_r1989431052


##########
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java:
##########
@@ -61,6 +61,14 @@ public interface ResourceManager extends ResourceService, 
Configurable {
                     + "To force-stop VMs, choose 'ForceStop' strategy",
             true, ConfigKey.Scope.Global, null, null, null, null, null, 
ConfigKey.Kind.Select, "Error,Migration,ForceStop");
 
+    ConfigKey<String> SystemVmPreferredArchitecture = new 
ConfigKey<>("Advanced"
+            , String.class
+            , "system.vm.preferred.architecture"
+            , ""
+            , "Preferred architecture for the system VMs including virtual 
routers"
+            , true
+            , ConfigKey.Scope.Zone);

Review Comment:
   Is it possible to use this 
[constructor](https://github.com/apache/cloudstack/blob/4.20/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java#L160-L176)
 to define the configKey with kind: Select and specify options which probably 
would be helpful in the UI.
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to