rohityadavcloud commented on code in PR #10500:
URL: https://github.com/apache/cloudstack/pull/10500#discussion_r1984373692
##########
framework/cluster/src/main/java/com/cloud/cluster/ClusterManagerImpl.java:
##########
@@ -1107,9 +1107,19 @@ public boolean stop() {
if (_mshostId != null) {
final ManagementServerHostVO mshost = _mshostDao.findByMsid(_msId);
if (mshost != null) {
- final ManagementServerStatusVO mshostStatus =
mshostStatusDao.findByMsId(mshost.getUuid());
- mshostStatus.setLastJvmStop(new Date());
- mshostStatusDao.update(mshostStatus.getId(), mshostStatus);
+ ManagementServerStatusVO mshostStatus =
mshostStatusDao.findByMsId(mshost.getUuid());
+ if (mshostStatus != null) {
+ mshostStatus.setLastJvmStop(new Date());
+ mshostStatusDao.update(mshostStatus.getId(), mshostStatus);
+ } else {
+ logger.warn("an MS host, [{}] without a status? this
should never happen!", mshost);
Review Comment:
```suggestion
logger.warn("Found a management server host [{}] without
a status. This should never happen!", mshost);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
