weizhouapache commented on code in PR #10376:
URL: https://github.com/apache/cloudstack/pull/10376#discussion_r1975726310


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java:
##########
@@ -37,6 +38,26 @@ public final class LibvirtGetVmIpAddressCommandWrapper 
extends CommandWrapper<Ge
 
     private static final Logger s_logger = 
Logger.getLogger(LibvirtGetVmIpAddressCommandWrapper.class);
 
+    static String virsh_path = null;
+    static String virt_win_reg_path = null;
+    static String grep_path = null;
+    static String awk_path = null;
+    static String sed_path = null;
+    static String virt_ls_path = null;
+    static String virt_cat_path = null;
+    static String tail_path = null;
+
+    static void init() {

Review Comment:
   @rg9975 
   the method is never used in LibvirtGetVmIpAddressCommandWrapper.java
   which breaks the functionality
   
   I will fix it in #10431 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to