Pearl1594 commented on code in PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1972770217
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -99,7 +151,16 @@ delete_backup() {
mount_operation() {
mount_point=$(mktemp -d -t csbackup.XXXXX)
dest="$mount_point/${BACKUP_DIR}"
- mount -t ${NAS_TYPE} ${NAS_ADDRESS} ${mount_point} $([[ ! -z "${MOUNT_OPTS}"
]] && echo -o ${MOUNT_OPTS})
+ if [ ${NAS_TYPE} == "cifs" ]; then
+ MOUNT_OPTS="${MOUNT_OPTS},nobrl"
Review Comment:
I had faced the following issue while backing up the VM:
```
# virsh -c qemu:///system backup-begin --domain i-2-10-VM --backupxml
/tmp/csbackup.HEGID/i-2-10-VM/2024.10.07.02.44.28/backup.xml
error: operation failed: failed to format image: 'Could not write qcow2
header: Permission denied'
```
As per
https://unix.stackexchange.com/questions/622194/how-to-use-qemu-kvm-virtual-machine-disk-image-on-smb-cifs-network-share-permis
adding nobrl solved it - so I used that fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
