weizhouapache commented on PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#issuecomment-2684147652
@Pearl1594 thanks for the update. I checked the `counter` table in my database, it has unique key ``` UNIQUE KEY `uc_counter__provider__source__value` (`provider`,`source`,`value`), ``` the reporter also mentioned ``` deleteCounter function removes counter and allow us to create a counter with the same value ``` so it looks like the counter name can be same as other counters, sorry my bad. currently if create a counter with same provider/source/value, it throws exception `entity exists` due to the new unique key, which is not very clear to users. It would be good to replace the check on `name` with `value` in your PR, for example ``` - findByNameProviderSource(String name, String source, String provider) + findByNameProviderValue(String name, String value, String provider) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
