vishesh92 commented on code in PR #10252:
URL: https://github.com/apache/cloudstack/pull/10252#discussion_r1954833566
##########
server/src/test/java/com/cloud/alert/AlertManagerImplTest.java:
##########
@@ -45,7 +53,7 @@ public class AlertManagerImplTest {
AlertManagerImpl alertManagerImplMock;
@Mock
- AlertDao alertDaoMock;
+ AlertDao _alertDao;
Review Comment:
It's better to have the same name for the field which is in the
`AlertManagerImpl` to avoid issues. I don't remember exactly but some tests
were failing earlier when the field name was different in the test file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
