lucas-a-martins opened a new pull request, #10389:
URL: https://github.com/apache/cloudstack/pull/10389

   ### Description
   
   When creating a L2 network offering via UI, the compute offering parameter 
is required despite L2 networks not using a virtual router and the compute 
offering itself.
   
   This PR removes the compute offering parameter from `Add Network Offering` 
form when L2 guest type is selected.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### Screenshots (if appropriate):
   
   
![L2-network-offering-PR](https://github.com/user-attachments/assets/91269841-f300-46db-98c9-5d494e54d844)
   
   ### How Has This Been Tested?
   
   As shown in the screenshot above, the compute offering option is no longer 
present when selecting L2 guest type. By selecting the Isolated and Shared 
types, I checked that the parameter still available.
   
   I also created some network offerings of each type and everything is working 
as intended.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to