andrijapanicsb commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1820489290
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -380,9 +381,14 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
vsDisplayName, String vsDesc
//StorageVMSnapshotStrategy - allows volume snapshots without
memory; VM has to be in Running state; No limitation of the image format if the
storage plugin supports volume snapshots; "kvm.vmstoragesnapshot.enabled" has
to be enabled
//Other Storage volume plugins could integrate this with their own
functionality for group snapshots
VMSnapshotStrategy snapshotStrategy =
storageStrategyFactory.getVmSnapshotStrategy(userVmVo.getId(),
rootVolumePool.getId(), snapshotMemory);
-
if (snapshotStrategy == null) {
- String message = "KVM does not support the type of snapshot
requested";
+ String message;
+ if (!SnapshotManager.VmStorageSnapshotKvm.value() &&
!snapshotMemory) {
+ message = "KVM does not support instance snapshot without
snapshot memory on a running instance";
Review Comment:
@abh1sar can you review this one pls? It's just the English wording.
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -380,9 +381,14 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
vsDisplayName, String vsDesc
//StorageVMSnapshotStrategy - allows volume snapshots without
memory; VM has to be in Running state; No limitation of the image format if the
storage plugin supports volume snapshots; "kvm.vmstoragesnapshot.enabled" has
to be enabled
//Other Storage volume plugins could integrate this with their own
functionality for group snapshots
VMSnapshotStrategy snapshotStrategy =
storageStrategyFactory.getVmSnapshotStrategy(userVmVo.getId(),
rootVolumePool.getId(), snapshotMemory);
-
if (snapshotStrategy == null) {
- String message = "KVM does not support the type of snapshot
requested";
+ String message;
+ if (!SnapshotManager.VmStorageSnapshotKvm.value() &&
!snapshotMemory) {
+ message = "KVM does not support instance snapshot without
snapshot memory on a running instance";
Review Comment:
```suggestion
message = "Creating a snapshot of a running KVM instance
without memory is not supported";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
