weizhouapache commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1939172225


##########
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##########
@@ -115,6 +115,8 @@ setup_vpcrouter() {
   sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g" 
/usr/lib/systemd/system/logrotate.timer
   sed -i 's#^AccuracySec=.*#AccuracySec=5m#g' 
/usr/lib/systemd/system/logrotate.timer
 
+  sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/' 
/etc/dnsmasq.conf

Review Comment:
   just curious, this setting does not exist in VR of isolated networks as well
   
   ```
   root@r-1171-VM:~# grep -r dnsmasq.leases /etc/dnsmasq*
   /etc/dnsmasq.conf:#dhcp-leasefile=/var/lib/misc/dnsmasq.leases
   /etc/dnsmasq.conf.tmpl:#dhcp-leasefile=/var/lib/misc/dnsmasq.leases
   ```
   
   Does the issue exist with redundant VRs of isolated network as well ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to