weizhouapache commented on code in PR #10262:
URL: https://github.com/apache/cloudstack/pull/10262#discussion_r1928894946
##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -551,6 +552,20 @@ def fw_vpcrouter(self):
self.fw.append(["mangle", "front",
"-A PREROUTING -s %s -d %s -m state --state NEW -j
MARK --set-xmark %s/0xffffffff" %
(self.cl.get_vpccidr(), self.address['network'],
hex(100 + int(self.dev[3:])))])
+
+ static_routes = CsStaticRoutes("staticroutes", self.config)
+ if static_routes:
+ for item in static_routes.get_bag():
+ if item == "id":
+ continue
+ static_route = static_routes.get_bag()[item]
+ if static_route['ip_address'] == self.address['public_ip']
and not static_route['revoke']:
+ self.fw.append(["mangle", "",
+ "-A PREROUTING -m state --state NEW -i
%s -s %s ! -d %s/32 -j ACL_OUTBOUND_%s" %
+ (self.dev, static_route['network'],
static_route['ip_address'], self.dev)])
+ self.fw.append(["filter", "", "-A FORWARD -d %s -o %s
-j ACL_INBOUND_%s" %
Review Comment:
```suggestion
self.fw.append(["filter", "front", "-A FORWARD -d %s
-o %s -j ACL_INBOUND_%s" %
```
to fix the similar issue as #9838
##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -551,6 +552,20 @@ def fw_vpcrouter(self):
self.fw.append(["mangle", "front",
"-A PREROUTING -s %s -d %s -m state --state NEW -j
MARK --set-xmark %s/0xffffffff" %
(self.cl.get_vpccidr(), self.address['network'],
hex(100 + int(self.dev[3:])))])
+
+ static_routes = CsStaticRoutes("staticroutes", self.config)
+ if static_routes:
+ for item in static_routes.get_bag():
+ if item == "id":
+ continue
+ static_route = static_routes.get_bag()[item]
+ if static_route['ip_address'] == self.address['public_ip']
and not static_route['revoke']:
Review Comment:
```suggestion
if 'ip_address' in static_route and
static_route['ip_address'] == self.address['public_ip'] and not
static_route['revoke']:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
