Pearl1594 commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2605474325
> > Right. That has been the historic behavior. But personally I find it less user friendly that those (default) offerings aren't listed for tagged phy networks and one needs to explicitly create network offerings if they add additional physical networks. > > indeed. for shared network, we could improve it as the physical network id is passed so tags check might be unnecessary. for isolated/l2 network, I have no idea how to improve it. @weizhouapache I can add a check for guestType = Shared, before searching for offerings based on the tags - however, historically too tags were being used to filter out the offerings listed irrespective of the network type. Do we want this behavior to change cc @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
