DaanHoogland commented on code in PR #10218:
URL: https://github.com/apache/cloudstack/pull/10218#discussion_r1923959318


##########
server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java:
##########
@@ -189,7 +187,6 @@ public HostResponse newHostResponse(HostJoinVO host, 
EnumSet<HostDetails> detail
         DecimalFormat decimalFormat = new DecimalFormat("#.##");
         if (host.getType() == Host.Type.Routing) {
             float cpuOverprovisioningFactor = 
ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId());
-            hostResponse.setCpuNumber((int)(host.getCpus() * 
cpuOverprovisioningFactor));

Review Comment:
   OK, cpu number is already set and don't override it :+1:  (see line 123)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to