weizhouapache commented on code in PR #10201:
URL: https://github.com/apache/cloudstack/pull/10201#discussion_r1918824506
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -126,18 +126,24 @@ public List<StoragePool> allocateToPool(DiskProfile
dskCh, VirtualMachineProfile
protected List<StoragePool> reorderPoolsByCapacity(DeploymentPlan plan,
List<StoragePool> pools) {
Long zoneId = plan.getDataCenterId();
Long clusterId = plan.getClusterId();
- short capacityType;
if (CollectionUtils.isEmpty(pools)) {
return null;
}
- if (pools.get(0).getPoolType().isShared()) {
Review Comment:
@bernardodemarco
if I understand correctly, the main change is similar as
```
if (pools.get(0).isShared()) {
```
right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
