DaanHoogland commented on PR #9590: URL: https://github.com/apache/cloudstack/pull/9590#issuecomment-2593182480
> Hey @DaanHoogland, my idea of removing the credits listing from `quotaBalance` was to make each API have a single responsibility and make credits-related code changes easier in the future (as we would not have to worry about checking and updating `quotaBalance` accordingly anymore when introducing these changes). I don't have a stronger argument for it 😅 > > Regarding the gravity of removing it: Quota users would be advised to use `quotaCreditsList` to list credit additions instead. However, scripts/automation tools/external software that use `quotaBalance` to get the credit addition history of accounts and were not updated before upgrading CloudStack would break. The Quota UI currently uses it to show a list containing the balance and credit addition entries at the same time, but this page will be reworked in the future to separate them, using `quotaCreditsList` for listing credit additions instead. > > As it would definitely have an impact, I understand why we would want to keep this information in the response, so I'm okay with not removing it. The enhancements to `quotaBalance` will still be made without this change. @winterhazel , clear, your call..! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
