DaanHoogland commented on code in PR #10168:
URL: https://github.com/apache/cloudstack/pull/10168#discussion_r1910003100
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1634,6 +1634,18 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
throwInvalidIdException("Network offering with specified id
doesn't support adding multiple ip ranges", ntwkOff.getUuid(),
NETWORK_OFFERING_ID);
}
+ if (GuestType.Shared == ntwkOff.getGuestType()) {
+ if (!ntwkOff.isSpecifyIpRanges()) {
+ throw new CloudRuntimeException("Specify IP Ranged should be
true for Shared Networks");
+ }
+ if (ipv4 && Objects.isNull(startIP)) {
Review Comment:
in the ipv6 case we have to deal with SLAAC. I don't think we should
considder this in this fix. If at all, it is a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
