sureshanaparti commented on code in PR #9873:
URL: https://github.com/apache/cloudstack/pull/9873#discussion_r1900326964
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLManagerImpl.java:
##########
@@ -206,15 +206,15 @@ public boolean replaceNetworkACL(final NetworkACL acl,
final NetworkVO network)
logger.debug("New network ACL is empty. Revoke existing rules
before applying ACL");
} else {
if (!revokeACLItemsForNetwork(network.getId())) {
- throw new CloudRuntimeException("Failed to replace network
ACL. Error while removing existing ACL items for network: " + network.getId());
+ throw new CloudRuntimeException(String.format("Failed to
replace network ACL. Error while removing existing ACL items for network: %s",
network));
}
}
}
network.setNetworkACLId(acl.getId());
//Update Network ACL
if (_networkDao.update(network.getId(), network)) {
- logger.debug("Updated network: " + network.getId() + " with
Network ACL Id: " + acl.getId() + ", Applying ACL items");
+ logger.debug("Updated network: {} with Network ACL Id: {},
Applying ACL items", network, acl);
Review Comment:
```suggestion
logger.debug("Updated network: {} with Network ACL: {}, Applying
ACL items", network, acl);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
