This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push: new 6a2c7b02201 pre-commit: enable markdownlint rule `MD012` (#9364) 6a2c7b02201 is described below commit 6a2c7b02201312f0ff95e7b020ca26cc49263dbb Author: John Bampton <jbamp...@users.noreply.github.com> AuthorDate: Fri Dec 27 19:25:11 2024 +1000 pre-commit: enable markdownlint rule `MD012` (#9364) MD012 no-multiple-blanks - Multiple consecutive blank lines https://github.com/DavidAnson/markdownlint/blob/main/doc/md012.md --- .github/linters/.markdown-lint.yml | 3 --- CHANGES.md | 6 ------ CONTRIBUTING.md | 5 ----- ISSUE_TEMPLATE.md | 3 --- PULL_REQUEST_TEMPLATE.md | 3 --- plugins/storage/volume/storpool/README.md | 6 ------ tools/devcloud4/README.md | 4 ---- tools/devcloud4/advanced/README.md | 2 -- tools/devcloud4/basic/README.md | 2 -- tools/docker/README.md | 4 ---- tools/marvin/marvin/misc/build/CI.md | 3 --- tools/marvin/marvin/misc/build/README.md | 1 - ui/docs/development.md | 2 -- ui/src/style/README.md | 1 - 14 files changed, 45 deletions(-) diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml index df1b1a2825e..421ca05bd42 100644 --- a/.github/linters/.markdown-lint.yml +++ b/.github/linters/.markdown-lint.yml @@ -33,9 +33,6 @@ MD009: false # MD010/no-hard-tabs Hard tabs MD010: false -# MD012/no-multiple-blanks Multiple consecutive blank lines -MD012: false - # MD013/line-length Line length MD013: false diff --git a/CHANGES.md b/CHANGES.md index 9544fc014c7..8fea4f3a355 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -242,7 +242,6 @@ Bug ID | Description [CLOUDSTACK-7722](https://issues.apache.org/jira/browse/CLOUDSTACK-7722) | add.label: Add button for tags show the label not "Add" text... [CLOUDSTACK-7246](https://issues.apache.org/jira/browse/CLOUDSTACK-7246) | VM deployment failed due to wrong in script name createipalias.sh... - Version 4.4.1 ------------- @@ -276,7 +275,6 @@ Bug ID | Description [CLOUDSTACK-1632](https://issues.apache.org/jira/browse/CLOUDSTACK-1632) | Mistakes in authorizeSecurityGroup* API docs... [CLOUDSTACK-401](https://issues.apache.org/jira/browse/CLOUDSTACK-401) | Storage options missing from table... - Version 4.4.0 ------------- @@ -930,7 +928,6 @@ Security Fixes: * CVE-2012-4501: Apache CloudStack configuration vulnerability - Version 4.0.2 ------------------------ @@ -979,7 +976,6 @@ Issues fixed in this release: * CLOUDSTACK-2090: Upgrade from version 4.0.1 to version 4.0.2 triggers the 4.0.0 to 4.0.1. * CLOUDSTACK-2091: Error in API documentation for 4.0.x. - Version 4.0.1-incubating ------------------------ @@ -1023,7 +1019,6 @@ Bugs fixed in this release: * CLOUDSTACK-961: Installation docs don't detail dependencies for building RPMs * CLOUDSTACK-995: Not able to add the KVM host - Version 4.0.0-incubating ------------------------ @@ -1056,7 +1051,6 @@ Security Fixes: * CVE-2012-4501: Apache CloudStack configuration vulnerability - Updating this file ------------------ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bb84e4e91fb..59436d36a27 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,11 +51,9 @@ $ git fetch upstream $ git rebase upstream/main ``` - Making changes -------------- - It is important that you create a new branch to make changes on and that you do not change the `main` branch (other than to rebase in changes from `upstream/main`). In this example I will assume you will be making your changes to a branch called `feature_x`. This `feature_x` branch will be created on your local repository and will be pushed to your forked repository on GitHub. Once this branch is on your fork you will create a Pull Request for the changes to be added to the ACS project. It is best practice to create a new branch each time you want to contribute to the project and only track the changes for that pull request in this branch. @@ -70,7 +68,6 @@ $ git commit -a -m "descriptive commit message for your changes" > The `-b` specifies that you want to create a new branch called `feature_x`. > You only specify `-b` the first time you checkout because you are creating a > new branch. Once the `feature_x` branch exists, you can later switch to it > with only `git checkout feature_x`. - Rebase `feature_x` to include updates from `upstream/main` ------------------------------------------------------------ @@ -92,7 +89,6 @@ $ git rebase main > Now your `feature_x` branch is up-to-date with all the code in > `upstream/main`. - Make a GitHub Pull Request to contribute your changes ----------------------------------------------------- @@ -118,7 +114,6 @@ To initiate the pull request, do the following: If you are requested to make modifications to your proposed changes, make the changes locally on your `feature_x` branch, re-push the `feature_x` branch to your fork. The existing pull request should automatically pick up the change and update accordingly. - Cleaning up after a successful pull request ------------------------------------------- diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md index 85c1ac9ec6a..4a48a4e7591 100644 --- a/ISSUE_TEMPLATE.md +++ b/ISSUE_TEMPLATE.md @@ -35,17 +35,14 @@ New line separated list of affected versions, commit ID for issues on main branc Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise --> - ##### OS / ENVIRONMENT <!-- Information about the environment if relevant, N/A otherwise --> - ##### SUMMARY <!-- Explain the problem/feature briefly --> - ##### STEPS TO REPRODUCE <!-- For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate. diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index e02cc651853..0bd7a7643ce 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -40,10 +40,8 @@ This PR... - [ ] Minor - [ ] Trivial - ### Screenshots (if appropriate): - ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> @@ -53,5 +51,4 @@ This PR... <!-- see how your change affects other areas of the code, etc. --> - <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> diff --git a/plugins/storage/volume/storpool/README.md b/plugins/storage/volume/storpool/README.md index 5cad0069621..a02896c42cd 100644 --- a/plugins/storage/volume/storpool/README.md +++ b/plugins/storage/volume/storpool/README.md @@ -11,7 +11,6 @@ Secondary storage stores the following: * ISO images — disc images containing data or bootable media for operating systems * Disk volume snapshots — saved copies of VM data which can be used for data recovery or to create new templates - ### ROOT and DATA volumes ROOT volumes correspond to the boot disk of a VM. They are created automatically by CloudStack during VM creation. @@ -21,7 +20,6 @@ is based on. We may change the ROOT volume disk offering but only to another sys DATA volumes correspond to additional disks. These can be created by users and then attached/detached to VMs. DATA volumes are created based on a user-defined disk offering. - ## Plugin Organization The StorPool plugin consists of two parts: @@ -49,7 +47,6 @@ that does pretty much the same. Note that for the present the StorPool plugin may only be used for a single primary storage cluster; support for multiple clusters is planned. - ## Build, Install, Setup ### Build @@ -122,7 +119,6 @@ SP_TEMPLATE - name of StorPool's template Storage Tags: If left blank, the StorPool storage plugin will use the pool name to create a corresponding storage tag. This storage tag may be used later, when defining service or disk offerings. - ## Plugin Functionality <table cellpadding="5"> @@ -361,7 +357,6 @@ Users who were using the offerings to change the StorPool template via the `SP_T - `resizeVolume` API call for DATA disk - `scaleVirtualMachine` API call for ROOT disk - If the disk offering has both `SP_TEMPLATE` and `SP_QOSCLASS` defined, the `SP_QOSCLASS` detail will be prioritised, setting the volume’s QoS using the respective ‘qc’ tag value. In case the QoS for a volume is changed manually, the ‘storpool_qos’ service will automatically reset the QoS limits following the ‘qc’ tag value once per minute. <h4>Usage</h4> @@ -374,7 +369,6 @@ Add disk offering detail with API call in CloudStack CLI. add resourcedetail resourcetype=diskoffering resourceid=$UUID details[0].key=SP_QOSCLASS details[0].value=$Tier Name - Creating VM with QoS Deploy virtual machine: Go to Compute> Instances> Add Instances. diff --git a/tools/devcloud4/README.md b/tools/devcloud4/README.md index 43e662b1a1d..96d33c914d4 100644 --- a/tools/devcloud4/README.md +++ b/tools/devcloud4/README.md @@ -71,15 +71,11 @@ The included VagrantFile will give you: #### For Advanced Networking you will need: - - ##### vboxnet1 - IPv4 IP address of 192.168.23.1 - Subnet of 255.255.255.0 - DHCP server disabled - - ##### vboxnet2 - IPv4 IP address of 192.168.24.1 - Subnet of 255.255.255.0 diff --git a/tools/devcloud4/advanced/README.md b/tools/devcloud4/advanced/README.md index 24082795026..986653fbc3b 100644 --- a/tools/devcloud4/advanced/README.md +++ b/tools/devcloud4/advanced/README.md @@ -21,7 +21,6 @@ - Subnet of 255.255.255.0 - DHCP server disabled - ### Start the vagrant boxes ```bash @@ -33,7 +32,6 @@ vagrant up - 'Cannot forward the specified ports on this VM': There could be MySQL or some other service running on the host OS causing vagrant to fail setting up local port forwarding. - ### Start Cloudstack 1. Clone the Cloudstack Repository: diff --git a/tools/devcloud4/basic/README.md b/tools/devcloud4/basic/README.md index c0ec6d89ecb..b0bfdaaa412 100644 --- a/tools/devcloud4/basic/README.md +++ b/tools/devcloud4/basic/README.md @@ -11,7 +11,6 @@ - Subnet of 255.255.255.0 - DHCP server disabled - ### Start the vagrant boxes ```bash @@ -23,7 +22,6 @@ vagrant up - 'Cannot forward the specified ports on this VM': There could be MySQL or some other service running on the host OS causing vagrant to fail setting up local port forwarding. - ### Start Cloudstack 1. Clone the Cloudstack Repository: diff --git a/tools/docker/README.md b/tools/docker/README.md index 84cb65bd437..0977b896606 100644 --- a/tools/docker/README.md +++ b/tools/docker/README.md @@ -2,10 +2,8 @@ Dockerfiles used to build CloudStack images are available on Docker hub. - ## Using images from docker-hub - ### CloudStack Simulator CloudStack Simulator is an all in one CloudStack Build including the simulator that mimic Hypervisor. This is useful to test CloudStack API behavior without having to deploy real hypervisor nodes. CloudStack Simulator is used for tests and CI. @@ -90,7 +88,6 @@ docker run -ti --rm --link simulator:8096 \ Image provided by CloudStack are automatically built by Jenkins performing following tasks: - ### CentOS 6 CentOS 6 image use RPM's from jenkins.buildacloud.org @@ -114,7 +111,6 @@ tag:latest = main branch docker commit -m "init system.iso" -a "Apache CloudStack" cloudstack cloudstack/management_centos6 ``` - ### Marvin Build Marvin container usable to deploy cloud in the CloudStack management server container. diff --git a/tools/marvin/marvin/misc/build/CI.md b/tools/marvin/marvin/misc/build/CI.md index 89df14bbf32..6b2a8582e63 100644 --- a/tools/marvin/marvin/misc/build/CI.md +++ b/tools/marvin/marvin/misc/build/CI.md @@ -15,7 +15,6 @@ # specific language governing permissions and limitations # under the License. - about ===== @@ -34,7 +33,6 @@ components . scheduling . networking setup - [insert diagram here] The above illustration shows a high-level view of the test infrastructure setup. In this section we explain the tools and their organization in the infrastructure. The workflow detailed in a later section shows how this setup works together: @@ -96,7 +94,6 @@ b. multiple cluster c. inter-zone tests d. multi-pod tests - marvin integration ================== diff --git a/tools/marvin/marvin/misc/build/README.md b/tools/marvin/marvin/misc/build/README.md index 400d21d8d64..df339e18ee1 100644 --- a/tools/marvin/marvin/misc/build/README.md +++ b/tools/marvin/marvin/misc/build/README.md @@ -15,7 +15,6 @@ #specific language governing permissions and limitations #under the License. - #Cloud AutoDeploy Scripts here are used to refresh the builds of the management server with those diff --git a/ui/docs/development.md b/ui/docs/development.md index dfee2b61331..8b1f67b7c42 100644 --- a/ui/docs/development.md +++ b/ui/docs/development.md @@ -60,7 +60,6 @@ import the new section's (newconfig.js as example) configuration file and rules generateRouterMap(newSection), - ### Section An existing or new section's config/js file must export the following parameters: @@ -81,7 +80,6 @@ An existing or new section's config/js file must export the following parameters - `component`: When children is not defined, the custom component for rendering the route view - See `src/config/section/compute.js` and `src/config/section/project.js` for example. The children should have: diff --git a/ui/src/style/README.md b/ui/src/style/README.md index 391c66565d4..6cdf3dfea39 100644 --- a/ui/src/style/README.md +++ b/ui/src/style/README.md @@ -38,7 +38,6 @@ 7. components - complex elements like dropdown, forms, table, search (usually include this to components/FooterToolbar/ folder) - # The "/deep/" combinator - use the /deep/ combinator (or in other versions ">>>") helps us to exclude "scoped" rules into global - e.g. <style scoped> .a .b .c {}</style> will scope a generated data ID like .a .b .c[data-abcde] {}